From: Sangchul Lee <sc11.lee@samsung.com>
Date: Wed, 17 Jan 2024 06:57:51 +0000 (+0900)
Subject: webrtc_sink_dump: Check return value of g_strdup_printf()
X-Git-Tag: accepted/tizen/8.0/unified/20240118.170037^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e7f4c5c2347b0d2cf6543617f0d12d8266e39b14;p=platform%2Fcore%2Fapi%2Fwebrtc.git

webrtc_sink_dump: Check return value of g_strdup_printf()

[Version] 0.4.37
[Issue Type] Svace defect (DEREF_OF_NULL.RET.ALLOC)

Change-Id: I30166ee0e3661a9e3aab51cf9f845471ff1d15a4
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
---

diff --git a/packaging/capi-media-webrtc.spec b/packaging/capi-media-webrtc.spec
index 73533816..4b63b4ac 100644
--- a/packaging/capi-media-webrtc.spec
+++ b/packaging/capi-media-webrtc.spec
@@ -1,6 +1,6 @@
 Name:       capi-media-webrtc
 Summary:    A WebRTC library in Tizen Native API
-Version:    0.4.36
+Version:    0.4.37
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
diff --git a/src/webrtc_sink_dump.c b/src/webrtc_sink_dump.c
index fe0ade0f..b239bae7 100644
--- a/src/webrtc_sink_dump.c
+++ b/src/webrtc_sink_dump.c
@@ -49,6 +49,8 @@ GstPadProbeReturn _depayloaded_data_probe_cb(GstPad *pad, GstPadProbeInfo *info,
 		sink->dump.path = g_strdup_printf("%s/webrtc-%p.sink%u.%s.%s.dump",
 			sink->webrtc->ini.general.dump_path, sink->webrtc, sink->id,
 			probe_data->av_idx == AV_IDX_AUDIO ? "audio" : "video", str_arr[1]);
+		RET_VAL_IF(sink->dump.path == NULL, GST_PAD_PROBE_REMOVE, "sink->dump.path is NULL");
+
 		sink->dump.fp = fopen(sink->dump.path, "w");
 		if (!sink->dump.fp) {
 			LOG_ERROR("failed to fopen() for %s, error:%s", sink->dump.path, g_strerror(errno));
@@ -130,4 +132,4 @@ void _remove_probe_from_pad_for_dump(webrtc_gst_slot_s *sink)
 		}
 	}
 }
-//LCOV_EXCL_STOP
\ No newline at end of file
+//LCOV_EXCL_STOP