From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Fri, 30 May 2014 22:20:11 +0000 (-0300)
Subject: [media] tlg2300: fix leak at failure path in poseidon_probe()
X-Git-Tag: v4.14-rc1~6092^2~1372
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e7d40c37215b2048685e72a0bb0101578c2b0a62;p=platform%2Fkernel%2Flinux-rpi.git

[media] tlg2300: fix leak at failure path in poseidon_probe()

Error handling code in poseidon_probe() misses usb_put_intf()
and usb_put_dev().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
---

diff --git a/drivers/media/usb/tlg2300/pd-main.c b/drivers/media/usb/tlg2300/pd-main.c
index 3316caa..b31f479 100644
--- a/drivers/media/usb/tlg2300/pd-main.c
+++ b/drivers/media/usb/tlg2300/pd-main.c
@@ -476,6 +476,8 @@ err_audio:
 err_video:
 	v4l2_device_unregister(&pd->v4l2_dev);
 err_v4l2:
+	usb_put_intf(pd->interface);
+	usb_put_dev(pd->udev);
 	kfree(pd);
 	return ret;
 }