From: Cheng Zhao Date: Wed, 13 Nov 2013 11:06:11 +0000 (+0800) Subject: Add "Renderer" suffix in name when crashing in renderer process. X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e7d25385b098833a865b175ddf1be7a762516caf;p=platform%2Fframework%2Fweb%2Fcrosswalk-tizen.git Add "Renderer" suffix in name when crashing in renderer process. --- diff --git a/common/crash_reporter/crash_reporter_mac.mm b/common/crash_reporter/crash_reporter_mac.mm index 5c27936..7ae2386 100644 --- a/common/crash_reporter/crash_reporter_mac.mm +++ b/common/crash_reporter/crash_reporter_mac.mm @@ -20,15 +20,16 @@ class ScopedCrashReporter { ScopedCrashReporter() : is_browser_(!base::mac::IsBackgroundOnlyProcess()) { NSMutableDictionary* parameters = [NSMutableDictionary dictionaryWithCapacity:4]; - [parameters setValue:@"Atom-Shell" forKey:@BREAKPAD_PRODUCT]; [parameters setValue:@"GitHub, Inc" forKey:@BREAKPAD_VENDOR]; - // Use application's version for crashes in browser. if (is_browser_) { + [parameters setValue:@"Atom-Shell" forKey:@BREAKPAD_PRODUCT]; + // Use application's version for crashes in browser. std::string version = atom::Browser::Get()->GetVersion(); [parameters setValue:base::SysUTF8ToNSString(version) forKey:@BREAKPAD_VERSION]; } else { + [parameters setValue:@"Atom-Shell Renderer" forKey:@BREAKPAD_PRODUCT]; [parameters setValue:@ATOM_VERSION_STRING forKey:@BREAKPAD_VERSION]; } @@ -49,6 +50,8 @@ class ScopedCrashReporter { ~ScopedCrashReporter() { if (breakpad_) BreakpadRelease(breakpad_); } + bool is_browser() const { return is_browser_; } + void SetKey(const std::string& key, const std::string& value) { BreakpadSetKeyValue(breakpad_, base::SysUTF8ToNSString(key),