From: Tomas Mlcoch <tmlcoch@redhat.com>
Date: Tue, 2 Jul 2013 12:25:07 +0000 (+0200)
Subject: Prevent returning of uninitialized values from cr_xml_dump.
X-Git-Tag: upstream/0.2.1~53
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e7a6256fc8973b6e1184786978fbfe2d8c254eb5;p=services%2Fcreaterepo_c.git

Prevent returning of uninitialized values from cr_xml_dump.
---

diff --git a/src/load_metadata.h b/src/load_metadata.h
index 976d036..693de49 100644
--- a/src/load_metadata.h
+++ b/src/load_metadata.h
@@ -81,10 +81,6 @@ cr_HashTableKey cr_metadata_key(cr_Metadata *md);
  */
 GHashTable *cr_metadata_hashtable(cr_Metadata *md);
 
-// XXX TODO Remove
-/** Return GStringChunk from a cr_Metadata */
-//#define cr_metadata_chunk(X)        ((X)->chunk)
-
 /** Create new (empty) metadata hashtable.
  * It is NOT thread safe to load data into single cr_Metadata
  * from multiple threads. But non modifying access to the loaded data
diff --git a/src/xml_dump.c b/src/xml_dump.c
index f949c53..69458f0 100644
--- a/src/xml_dump.c
+++ b/src/xml_dump.c
@@ -186,12 +186,12 @@ cr_xml_dump(cr_Package *pkg, GError **err)
 
     assert(!err || *err == NULL);
 
-    if (!pkg) {
-        result.primary   = NULL;
-        result.filelists = NULL;
-        result.other     = NULL;
+    result.primary   = NULL;
+    result.filelists = NULL;
+    result.other     = NULL;
+
+    if (!pkg)
         return result;
-    }
 
     result.primary = cr_xml_dump_primary(pkg, &tmp_err);
     if (tmp_err) {