From: Jens Axboe <axboe@kernel.dk>
Date: Wed, 28 Sep 2022 15:19:59 +0000 (-0600)
Subject: block: kill deprecated BUG_ON() in the flush handling
X-Git-Tag: v6.1-rc5~282^2~18
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e73a625bc24880f1fe5abaa89bb63e0918fbd66c;p=platform%2Fkernel%2Flinux-starfive.git

block: kill deprecated BUG_ON() in the flush handling

We've never had any useful reports from this BUG_ON(), and in fact a
number of the BUG_ON()'s in the flush handling need to be turned into
more graceful handling.

In preparation for allowing batched completions of the end_io handling,
where we can enter the flush completion with queuelist having been reused
for the batch, get rid of this BUG_ON().

Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/block/blk-flush.c b/block/blk-flush.c
index d20a0c6b..27705fc 100644
--- a/block/blk-flush.c
+++ b/block/blk-flush.c
@@ -205,7 +205,6 @@ static void blk_flush_complete_seq(struct request *rq,
 		 * flush data request completion path.  Restore @rq for
 		 * normal completion and end it.
 		 */
-		BUG_ON(!list_empty(&rq->queuelist));
 		list_del_init(&rq->flush.list);
 		blk_flush_restore_request(rq);
 		blk_mq_end_request(rq, error);