From: Abhimanyu Swami <abhimanyu1.s@samsung.com>
Date: Fri, 10 Jan 2020 04:19:18 +0000 (+0530)
Subject: Enable Build with GCC 9.2
X-Git-Tag: accepted/tizen/unified/20200115.123424^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e733f84d3ad93b32b0513bb098c8441166e9084f;p=platform%2Fcore%2Fpim%2Fcontacts-service.git

Enable Build with GCC 9.2

Change-Id: I982272c39a9070c97cc55063b1bbdb85f270547d
Signed-off-by: Abhimanyu Swami <abhimanyu1.s@samsung.com>
---

diff --git a/common/ctsvc_socket.c b/common/ctsvc_socket.c
index 189285d..4037f04 100644
--- a/common/ctsvc_socket.c
+++ b/common/ctsvc_socket.c
@@ -37,6 +37,7 @@ int ctsvc_socket_init(void)
 	int ret;
 	struct sockaddr_un caddr;
 	uid_t uid = getuid();
+	int wrn = 0;
 
 	WARN("ctsvc_socket_init: socket ref count : %d", __ctsvc_conn_refcnt);
 	if (0 < __ctsvc_conn_refcnt) {
@@ -55,12 +56,17 @@ int ctsvc_socket_init(void)
 	}
 #endif
 
-	snprintf(sock_file, sizeof(sock_file), CTSVC_SOCK_PATH"/%s", uid, CTSVC_SOCKET_FILE);
+	wrn = snprintf(sock_file, sizeof(sock_file), CTSVC_SOCK_PATH"/%s", uid, CTSVC_SOCKET_FILE);
+	if (wrn < 0){
+		WARN("Error writing in sock file (%s)", sock_file);
+	}
 
 	bzero(&caddr, sizeof(caddr));
 	caddr.sun_family = AF_UNIX;
-	snprintf(caddr.sun_path, sizeof(caddr.sun_path), "%s", sock_file);
-
+	wrn = snprintf(caddr.sun_path, sizeof(caddr.sun_path), "%s", sock_file);
+	if (wrn < 0){
+		WARN("Error writing in unix socket path (%s)", caddr.sun_path);
+	}
 	__ctsvc_sockfd = socket(PF_UNIX, SOCK_STREAM, 0);
 	RETVM_IF(-1 == __ctsvc_sockfd, CONTACTS_ERROR_IPC,
 			"socket() Fail(errno = %d)", errno);
diff --git a/server/ctsvc_server_socket.c b/server/ctsvc_server_socket.c
index fa90a18..7bbfd6f 100644
--- a/server/ctsvc_server_socket.c
+++ b/server/ctsvc_server_socket.c
@@ -497,6 +497,7 @@ int ctsvc_server_socket_init(void)
 	CTS_FN_CALL;
 
 	int ret;
+	int wrn;
 	struct sockaddr_un addr;
 	GIOChannel *gio;
 
@@ -508,8 +509,12 @@ int ctsvc_server_socket_init(void)
 
 	bzero(&addr, sizeof(addr));
 	addr.sun_family = AF_UNIX;
-	snprintf(addr.sun_path, sizeof(addr.sun_path), "%s", sock_file);
 
+	wrn = snprintf(addr.sun_path, sizeof(addr.sun_path), "%s", sock_file);
+
+	if (wrn < 0){
+		WARN("Error writing in sock file (%s)", sock_file);
+	}
 	sockfd = socket(PF_UNIX, SOCK_STREAM, 0);
 	RETVM_IF(-1 == sockfd, CONTACTS_ERROR_SYSTEM, "socket() Fail(errno = %d)", errno);
 
diff --git a/server/db/ctsvc_db_plugin_group.c b/server/db/ctsvc_db_plugin_group.c
index 4f0869d..1829a7b 100644
--- a/server/db/ctsvc_db_plugin_group.c
+++ b/server/db/ctsvc_db_plugin_group.c
@@ -174,6 +174,7 @@ static int __ctsvc_db_group_update_record(contacts_record_h record)
 {
 	int addressbook_id = 0;
 	int ret = CONTACTS_ERROR_NONE;
+	int wrn = 0;
 	char *set = NULL;
 	GSList *bind_text = NULL;
 	GSList *cursor = NULL;
@@ -317,7 +318,10 @@ static int __ctsvc_db_group_update_record(contacts_record_h record)
 			break;
 		snprintf(query_set, sizeof(query_set), "%s, changed_ver=%d ", set, ctsvc_get_next_ver());
 
-		snprintf(query, sizeof(query), "UPDATE %s SET %s WHERE group_id = %d", CTS_TABLE_GROUPS, query_set, group->id);
+		wrn = snprintf(query, sizeof(query), "UPDATE %s SET %s WHERE group_id = %d", CTS_TABLE_GROUPS, query_set, group->id);
+		if (wrn < 0)
+			WARN("Error writing in query set (%s)", query_set);
+
 		ret = ctsvc_query_prepare(query, &stmt);
 		if (NULL == stmt) {
 			/* LCOV_EXCL_START */
diff --git a/server/db/ctsvc_db_query.c b/server/db/ctsvc_db_query.c
index 6cb3746..a61ea08 100644
--- a/server/db/ctsvc_db_query.c
+++ b/server/db/ctsvc_db_query.c
@@ -4276,6 +4276,10 @@ static int __ctsvc_db_get_group_relations_changes(const char *view_uri,
 				"SELECT * FROM (%s) WHERE addressbook_id = %d ", temp_query, addressbook_id);
 	}
 
+	if (len < 0){
+		WARN("Error writing in query (%s)", query);
+	}
+
 	ret = ctsvc_query_prepare(query, &stmt);
 	RETVM_IF(NULL == stmt, ret, "ctsvc_query_prepare() Fail(%d)", ret);
 
diff --git a/server/db/ctsvc_db_sqlite.c b/server/db/ctsvc_db_sqlite.c
index dbd0e95..28a3379 100644
--- a/server/db/ctsvc_db_sqlite.c
+++ b/server/db/ctsvc_db_sqlite.c
@@ -286,7 +286,8 @@ int ctsvc_query_exec(const char *query)
 	ret = ctsvc_stmt_step(stmt);
 	if (CONTACTS_ERROR_NONE != ret)
 		/* LCOV_EXCL_START */
-		ERR("ctsvc_stmt_step() Fail(%d, %s)", ret, err_msg);
+		if (err_msg != NULL)
+			ERR("ctsvc_stmt_step() Fail(%d, %s)", ret, err_msg);
 	/* LCOV_EXCL_STOP */
 
 	ctsvc_stmt_finalize(stmt);
@@ -456,6 +457,6 @@ void ctsvc_stmt_finalize(cts_stmt stmt)
 
 	ret = sqlite3_finalize(stmt);
 	WARN_IF(ret != SQLITE_OK, "sqlite3_finalize Fail(%d, %s, %d)",
-			ret, sqlite3_errmsg(ctsvc_db), sqlite3_extended_errcode(ctsvc_db));
+	ret, sqlite3_errmsg(ctsvc_db), sqlite3_extended_errcode(ctsvc_db));
 }