From: Jia-Ju Bai Date: Thu, 25 Jan 2018 10:26:52 +0000 (+0800) Subject: ata: sata_mv: Replace mdelay with usleep_range in mv_reset_channel X-Git-Tag: v4.19~1735^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e72685dbd2e7782ce99ccd198e52dc0d9cf1d16f;p=platform%2Fkernel%2Flinux-rpi.git ata: sata_mv: Replace mdelay with usleep_range in mv_reset_channel After checking all possible call chains to mv_reset_channel here, my tool finds that mv_reset_channel is never called in atomic context, namely never in an interrupt handler or holding a spinlock. Thus mdelay can be replaced with usleep_range to avoid busy wait. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai Signed-off-by: Tejun Heo --- diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index cc208b7..42d4589 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -3596,7 +3596,7 @@ static void mv_reset_channel(struct mv_host_priv *hpriv, void __iomem *mmio, hpriv->ops->phy_errata(hpriv, mmio, port_no); if (IS_GEN_I(hpriv)) - mdelay(1); + usleep_range(500, 1000); } static void mv_pmp_select(struct ata_port *ap, int pmp)