From: Kenneth Graunke <kenneth@whitecape.org>
Date: Mon, 7 May 2018 18:14:42 +0000 (-0700)
Subject: intel/genxml: Assert that genxml field start and ends are sane.
X-Git-Tag: upstream/19.0.0~5272
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e6fb8196cea78f56dc554eb226b97570ef90355d;p=platform%2Fupstream%2Fmesa.git

intel/genxml: Assert that genxml field start and ends are sane.

Chris recently fixed a bunch of genxml end < start bugs, as well as
booleans that are wider than a bit.  These are way too easy to write, so
asserting that the fields are sane is a good plan.

Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Acked-by: Jason Ekstrand <jason@jlekstrand.net>
---

diff --git a/src/intel/genxml/gen_pack_header.py b/src/intel/genxml/gen_pack_header.py
index 4bce425..c3d712c 100644
--- a/src/intel/genxml/gen_pack_header.py
+++ b/src/intel/genxml/gen_pack_header.py
@@ -235,6 +235,13 @@ class Field(object):
         self.end = int(attrs["end"])
         self.type = attrs["type"]
 
+        assert self.start <= self.end, \
+               'field {} has end ({}) < start ({})'.format(self.name, self.end,
+                                                           self.start)
+        if self.type == 'bool':
+            assert self.end == self.start, \
+                   'bool field ({}) is too wide'.format(self.name)
+
         if "prefix" in attrs:
             self.prefix = attrs["prefix"]
         else: