From: Valentin Vidic Date: Sat, 27 Jan 2018 09:42:16 +0000 (+0100) Subject: staging: pi433: fix CamelCase for regValue X-Git-Tag: v5.15~9122^2~458 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e6dd870a0080787b472ab8895bef91486c70ebcf;p=platform%2Fkernel%2Flinux-starfive.git staging: pi433: fix CamelCase for regValue Local variable storing the new value for dio register so replace with dio_value. Update regaddr to dio_addr to match. Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index ef56dec..42c2e1c 100644 --- a/drivers/staging/pi433/rf69.c +++ b/drivers/staging/pi433/rf69.c @@ -505,27 +505,27 @@ int rf69_set_dio_mapping(struct spi_device *spi, u8 DIONumber, u8 value) { u8 mask; u8 shift; - u8 regaddr; - u8 regValue; + u8 dio_addr; + u8 dio_value; switch (DIONumber) { case 0: - mask = MASK_DIO0; shift = SHIFT_DIO0; regaddr = REG_DIOMAPPING1; + mask = MASK_DIO0; shift = SHIFT_DIO0; dio_addr = REG_DIOMAPPING1; break; case 1: - mask = MASK_DIO1; shift = SHIFT_DIO1; regaddr = REG_DIOMAPPING1; + mask = MASK_DIO1; shift = SHIFT_DIO1; dio_addr = REG_DIOMAPPING1; break; case 2: - mask = MASK_DIO2; shift = SHIFT_DIO2; regaddr = REG_DIOMAPPING1; + mask = MASK_DIO2; shift = SHIFT_DIO2; dio_addr = REG_DIOMAPPING1; break; case 3: - mask = MASK_DIO3; shift = SHIFT_DIO3; regaddr = REG_DIOMAPPING1; + mask = MASK_DIO3; shift = SHIFT_DIO3; dio_addr = REG_DIOMAPPING1; break; case 4: - mask = MASK_DIO4; shift = SHIFT_DIO4; regaddr = REG_DIOMAPPING2; + mask = MASK_DIO4; shift = SHIFT_DIO4; dio_addr = REG_DIOMAPPING2; break; case 5: - mask = MASK_DIO5; shift = SHIFT_DIO5; regaddr = REG_DIOMAPPING2; + mask = MASK_DIO5; shift = SHIFT_DIO5; dio_addr = REG_DIOMAPPING2; break; default: dev_dbg(&spi->dev, "set: illegal input param"); @@ -533,13 +533,13 @@ int rf69_set_dio_mapping(struct spi_device *spi, u8 DIONumber, u8 value) } // read reg - regValue = rf69_read_reg(spi, regaddr); + dio_value = rf69_read_reg(spi, dio_addr); // delete old value - regValue = regValue & ~mask; + dio_value = dio_value & ~mask; // add new value - regValue = regValue | value << shift; + dio_value = dio_value | value << shift; // write back - return rf69_write_reg(spi, regaddr, regValue); + return rf69_write_reg(spi, dio_addr, dio_value); } bool rf69_get_flag(struct spi_device *spi, enum flag flag)