From: Peter Ujfalusi Date: Fri, 30 May 2014 13:47:41 +0000 (+0300) Subject: ASoC: tlv320aci3x: Fix custom snd_soc_dapm_put_volsw_aic3x() function X-Git-Tag: v4.9.8~6235^2~24^2~14^3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e6c111fac4464e3f4bf7b3802b517dafc80f8e0f;p=platform%2Fkernel%2Flinux-rpi3.git ASoC: tlv320aci3x: Fix custom snd_soc_dapm_put_volsw_aic3x() function For some unknown reason the parameters for snd_soc_test_bits() were in wrong order: It was: snd_soc_test_bits(codec, val, mask, reg); /* WRONG!!! */ while it should be: snd_soc_test_bits(codec, reg, mask, val); Signed-off-by: Peter Ujfalusi Signed-off-by: Mark Brown Cc: stable@vger.kernel.org --- diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c index b183510..5498393 100644 --- a/sound/soc/codecs/tlv320aic3x.c +++ b/sound/soc/codecs/tlv320aic3x.c @@ -169,7 +169,7 @@ static int snd_soc_dapm_put_volsw_aic3x(struct snd_kcontrol *kcontrol, mask <<= shift; val <<= shift; - change = snd_soc_test_bits(codec, val, mask, reg); + change = snd_soc_test_bits(codec, reg, mask, val); if (change) { update.kcontrol = kcontrol; update.reg = reg;