From: Ville Syrjälä Date: Thu, 12 Mar 2015 15:10:37 +0000 (+0200) Subject: drm/i915: Avoid overflowing the DP link rate arrays X-Git-Tag: v4.1~210^2^2~88 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e6bda3e4cb439679946c9378628d906ab32bf590;p=platform%2Fkernel%2Flinux-amlogic.git drm/i915: Avoid overflowing the DP link rate arrays Complain loudly if we ever attempt to overflow the the supported_rates[] array. This should never happen since the sink_rates[] array will always be smaller or of equal size. But should someone change that we want to catch it without scribblign over the stack. Signed-off-by: Ville Syrjälä Reviewed-by: Sonika Jindal Signed-off-by: Daniel Vetter --- diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index c02e022..ff0aa6f 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -1203,6 +1203,8 @@ static int intersect_rates(const int *source_rates, int source_len, while (i < source_len && j < sink_len) { if (source_rates[i] == sink_rates[j]) { + if (WARN_ON(k >= DP_MAX_SUPPORTED_RATES)) + return k; supported_rates[k] = source_rates[i]; ++k; ++i;