From: Stefan Roese Date: Mon, 24 Aug 2020 11:04:37 +0000 (+0200) Subject: usb: xhci: xhci_bulk_tx: Don't "BUG" when comparing addresses X-Git-Tag: v2021.10~492^2~16 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e68efa1ecf4552158451f9b097fbcc15ce927489;p=platform%2Fkernel%2Fu-boot.git usb: xhci: xhci_bulk_tx: Don't "BUG" when comparing addresses Octeon uses mapped addresses for virtual and physical memory. It's not that easy to calculate the resulting addresses here. So let's remove this BUG_ON() completely, as it's not really helpful. Please also note, that BUG_ON() is not recommended any more in the Linux kernel. Signed-off-by: Stefan Roese Reviewed-by: Bin Meng Cc: Bin Meng Cc: Marek Vasut --- diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index b118207..13065d7 100644 --- a/drivers/usb/host/xhci-ring.c +++ b/drivers/usb/host/xhci-ring.c @@ -722,8 +722,6 @@ int xhci_bulk_tx(struct usb_device *udev, unsigned long pipe, BUG_ON(TRB_TO_SLOT_ID(field) != slot_id); BUG_ON(TRB_TO_EP_INDEX(field) != ep_index); - BUG_ON(*(void **)(uintptr_t)le64_to_cpu(event->trans_event.buffer) - - buffer > (size_t)length); record_transfer_result(udev, event, length); xhci_acknowledge_event(ctrl);