From: Maciej Jesionowski Date: Wed, 4 Oct 2017 17:08:12 +0000 (+0200) Subject: Avoid 32-bit precision issues in ShaderRender tests X-Git-Tag: upstream/1.3.5~2565^2~6^2~94 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e68883ec831b98c5fb4eddf6239e0eee9a376d2f;p=platform%2Fupstream%2FVK-GL-CTS.git Avoid 32-bit precision issues in ShaderRender tests These tests are very sensitive to floating-point precision. The default GRID_SIZE of 90 units is problematic in 32-bit mode. The error is visible only in Release builds and affects CPU-generated reference image. Affects: * dEQP-VK.glsl.texture_functions.* * dEQP-VK.glsl.operator.* VK-GL-CTS issue: 751 Components: Vulkan Change-Id: I0ca501e180339cd0e1430cab3eb08a14f68f9802 --- diff --git a/external/vulkancts/modules/vulkan/shaderrender/vktShaderRenderOperatorTests.cpp b/external/vulkancts/modules/vulkan/shaderrender/vktShaderRenderOperatorTests.cpp index 246d7bc..baebda4 100644 --- a/external/vulkancts/modules/vulkan/shaderrender/vktShaderRenderOperatorTests.cpp +++ b/external/vulkancts/modules/vulkan/shaderrender/vktShaderRenderOperatorTests.cpp @@ -564,7 +564,8 @@ ShaderOperatorCaseInstance::ShaderOperatorCaseInstance (Context& context, const ShaderEvaluator& evaluator, const UniformSetup& uniformSetup, const ShaderDataSpec spec) - : ShaderRenderCaseInstance (context, isVertexCase, evaluator, uniformSetup, DE_NULL) + : ShaderRenderCaseInstance (context, isVertexCase, evaluator, uniformSetup, DE_NULL, IMAGE_BACKING_MODE_REGULAR, + (isVertexCase ? 92 : GRID_SIZE_DEFAULT_FRAGMENT)) , m_spec (spec) { // Setup the user attributes. diff --git a/external/vulkancts/modules/vulkan/shaderrender/vktShaderRenderTextureFunctionTests.cpp b/external/vulkancts/modules/vulkan/shaderrender/vktShaderRenderTextureFunctionTests.cpp index 43dc78b..be2e679 100644 --- a/external/vulkancts/modules/vulkan/shaderrender/vktShaderRenderTextureFunctionTests.cpp +++ b/external/vulkancts/modules/vulkan/shaderrender/vktShaderRenderTextureFunctionTests.cpp @@ -686,7 +686,8 @@ ShaderTextureFunctionInstance::ShaderTextureFunctionInstance (Context& cont const TextureSpec& textureSpec, const TexLookupParams& lookupParams, const ImageBackingMode imageBackingMode) - : ShaderRenderCaseInstance (context, isVertexCase, evaluator, uniformSetup, DE_NULL, imageBackingMode) + : ShaderRenderCaseInstance (context, isVertexCase, evaluator, uniformSetup, DE_NULL, imageBackingMode, + (isVertexCase ? 92 : GRID_SIZE_DEFAULT_FRAGMENT)) , m_lookupSpec (lookupSpec) , m_textureSpec (textureSpec) , m_lookupParams (lookupParams)