From: Heiner Kallweit Date: Sat, 28 Apr 2018 20:19:08 +0000 (+0200) Subject: r8169: remove unneeded call to __rtl8169_set_features in rtl_open X-Git-Tag: v4.19~872^2~345^2~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e66267483eab88a05103f2b9df6a5682b87f38b0;p=platform%2Fkernel%2Flinux-rpi.git r8169: remove unneeded call to __rtl8169_set_features in rtl_open RxChkSum and RxVlan aren't touched outside __rtl8169_set_features (except in probe), so they are always in sync with dev->features. And the RxConfig flags are set in rtl_set_rx_mode() which is called via dev_set_rx_mode() from __dev_open(). Therefore we can safely remove this call. Signed-off-by: Heiner Kallweit Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index a5d00ee..d2656224 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -7637,8 +7637,6 @@ static int rtl_open(struct net_device *dev) rtl8169_init_phy(dev, tp); - __rtl8169_set_features(dev, dev->features); - rtl_pll_power_up(tp); rtl_hw_start(tp);