From: Jacques Pienaar <jpienaar@google.com>
Date: Mon, 12 Aug 2019 16:02:07 +0000 (-0700)
Subject: Use unreachable post switch rather than default case.
X-Git-Tag: llvmorg-11-init~1466^2~1000
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e6365f3d0282a9d260967f45509912b368aee12c;p=platform%2Fupstream%2Fllvm.git

Use unreachable post switch rather than default case.

Prefer to enumerate all cases in the switch instead of using default to allow
compiler to flag missing cases. This also avoids -Wcovered-switch-default
warning.

PiperOrigin-RevId: 262935972
---

diff --git a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
index 7a84eae..19ff096 100644
--- a/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
@@ -135,9 +135,8 @@ static llvm::CmpInst::Predicate getLLVMCmpPredicate(ICmpPredicate p) {
     return llvm::CmpInst::Predicate::ICMP_UGT;
   case LLVM::ICmpPredicate::uge:
     return llvm::CmpInst::Predicate::ICMP_UGE;
-  default:
-    llvm_unreachable("incorrect comparison predicate");
   }
+  llvm_unreachable("incorrect comparison predicate");
 }
 
 static llvm::CmpInst::Predicate getLLVMCmpPredicate(FCmpPredicate p) {
@@ -174,9 +173,8 @@ static llvm::CmpInst::Predicate getLLVMCmpPredicate(FCmpPredicate p) {
     return llvm::CmpInst::Predicate::FCMP_UNO;
   case LLVM::FCmpPredicate::_true:
     return llvm::CmpInst::Predicate::FCMP_TRUE;
-  default:
-    llvm_unreachable("incorrect comparison predicate");
   }
+  llvm_unreachable("incorrect comparison predicate");
 }
 
 // A helper to look up remapped operands in the value remapping table.