From: H. Peter Anvin <hpa@zytor.com>
Date: Tue, 2 Sep 2008 23:14:28 +0000 (-0700)
Subject: isolinux: return failure when opening a zero-length file
X-Git-Tag: syslinux-3.72-pre1~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e61036415599f77a4bf133e0e9805f834c3adaa7;p=platform%2Fupstream%2Fsyslinux.git

isolinux: return failure when opening a zero-length file

In the Syslinux view of the world, a zero-length file doesn't exist
and therefore should return error on open.  A lot of the code relies
on this, but ISOLINUX allowed a zero-length file to be opened, which
could cause all kinds of trouble.

It would be nicer to not have that restriction, but removing it will
probably not happen until the configuration code is rewritten in C.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---

diff --git a/core/isolinux.asm b/core/isolinux.asm
index f7c1366..f93b24e 100644
--- a/core/isolinux.asm
+++ b/core/isolinux.asm
@@ -1232,7 +1232,8 @@ searchdir_iso:
 		shr eax,SECTOR_SHIFT
 		mov [bx+file_left],eax
 		pop eax
-		and bx,bx			; ZF = 0
+		jz .failure			; Empty file?
+		; ZF = 0
 		mov si,bx
 		pop es
 		ret