From: Glauber Costa Date: Mon, 28 Sep 2009 18:27:44 +0000 (-0300) Subject: do proper cpu_self check X-Git-Tag: TizenStudio_2.0_p2.3.2~208^2~10326 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e5bc201df7e060bc4c2912258a77c53f8901356c;p=sdk%2Femulator%2Fqemu.git do proper cpu_self check Currently, our check for qemu_cpu_self only checks if there is a cpu currently in execution (represented by cpu_single_env being set). While this might be okay for tcg, it is certainly not okay for kvm, since multiple cpus might be executing. Instead, I propose we use pthread primitives to test if the caller thread is the same as env->thread. For tcg, it will have the same semantics as before, since all CPUStates will point to the same thread, and we'll only have one in execution at a time. Signed-off-by: Glauber Costa Signed-off-by: Anthony Liguori --- diff --git a/vl.c b/vl.c index 4d9db01..19e11b2 100644 --- a/vl.c +++ b/vl.c @@ -3591,9 +3591,14 @@ void qemu_cpu_kick(void *_env) qemu_thread_signal(env->thread, SIGUSR1); } -int qemu_cpu_self(void *env) +int qemu_cpu_self(void *_env) { - return (cpu_single_env != NULL); + CPUState *env = _env; + QemuThread this; + + qemu_thread_self(&this); + + return qemu_thread_equal(&this, env->thread); } static void cpu_signal(int sig)