From: Fabio Estevam Date: Wed, 2 Dec 2020 23:24:48 +0000 (-0300) Subject: thermal: imx8mm: Disable the clock on probe failure X-Git-Tag: v5.15~2119^2~21 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e57eb8b5050c9b6d63eea26b194d96744fe4018a;p=platform%2Fkernel%2Flinux-starfive.git thermal: imx8mm: Disable the clock on probe failure Prior to returning an error in probe, disable the previously enabled clock. Signed-off-by: Fabio Estevam Signed-off-by: Daniel Lezcano Link: https://lore.kernel.org/r/20201202232448.2692-2-festevam@gmail.com --- diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c index ce7cb64..7442e01 100644 --- a/drivers/thermal/imx8mm_thermal.c +++ b/drivers/thermal/imx8mm_thermal.c @@ -170,7 +170,7 @@ static int imx8mm_tmu_probe(struct platform_device *pdev) dev_err(&pdev->dev, "failed to register thermal zone sensor[%d]: %d\n", i, ret); - return ret; + goto disable_clk; } tmu->sensors[i].hw_id = i; } @@ -185,6 +185,10 @@ static int imx8mm_tmu_probe(struct platform_device *pdev) imx8mm_tmu_enable(tmu, true); return 0; + +disable_clk: + clk_disable_unprepare(tmu->clk); + return ret; } static int imx8mm_tmu_remove(struct platform_device *pdev)