From: Max Reitz <mreitz@redhat.com>
Date: Mon, 27 Oct 2014 12:30:08 +0000 (+0100)
Subject: block: Propagate error in bdrv_img_create()
X-Git-Tag: TizenStudio_2.0_p2.3.2~208^2~475^2~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e56934becea70817124be1534f4289ce7d8f6733;p=sdk%2Femulator%2Fqemu.git

block: Propagate error in bdrv_img_create()

If the specified backing file could not be opened, do not generate a new
error message which contains the message which has been generated by
bdrv_open(), but just propagate the latter.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Peter Lieven <pl@kamp.de>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---

diff --git a/block.c b/block.c
index dacd881..4b5735c 100644
--- a/block.c
+++ b/block.c
@@ -5608,11 +5608,6 @@ void bdrv_img_create(const char *filename, const char *fmt,
             ret = bdrv_open(&bs, backing_file, NULL, NULL, back_flags,
                             backing_drv, &local_err);
             if (ret < 0) {
-                error_setg_errno(errp, -ret, "Could not open '%s': %s",
-                                 backing_file,
-                                 error_get_pretty(local_err));
-                error_free(local_err);
-                local_err = NULL;
                 goto out;
             }
             size = bdrv_getlength(bs);