From: Rémi Denis-Courmont Date: Tue, 25 May 2010 23:08:39 +0000 (-0700) Subject: Phonet: fix potential use-after-free in pep_sock_close() X-Git-Tag: v3.12-rc1~9544^2~207 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e513480e28cdfd868755f05c1a654fcfcee58070;p=kernel%2Fkernel-generic.git Phonet: fix potential use-after-free in pep_sock_close() sk_common_release() might destroy our last reference to the socket. So an extra temporary reference is needed during cleanup. Signed-off-by: Rémi Denis-Courmont Signed-off-by: David S. Miller --- diff --git a/net/phonet/pep.c b/net/phonet/pep.c index af4d38b..7b048a3 100644 --- a/net/phonet/pep.c +++ b/net/phonet/pep.c @@ -626,6 +626,7 @@ static void pep_sock_close(struct sock *sk, long timeout) struct pep_sock *pn = pep_sk(sk); int ifindex = 0; + sock_hold(sk); /* keep a reference after sk_common_release() */ sk_common_release(sk); lock_sock(sk); @@ -644,6 +645,7 @@ static void pep_sock_close(struct sock *sk, long timeout) if (ifindex) gprs_detach(sk); + sock_put(sk); } static int pep_wait_connreq(struct sock *sk, int noblock)