From: Kiseok Chang Date: Thu, 23 Jul 2020 09:57:54 +0000 (+0900) Subject: Remove TODO comments X-Git-Tag: submit/tizen/20200727.014020~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e504e105f44167d7a70b3e496279cc77c4c3648b;p=profile%2Fcommon%2Fapps%2Fnative%2Fsettings.git Remove TODO comments Change-Id: I196c0989c7ad50c05008bde9c245740e7ecd96f3 Signed-off-by: Kiseok Chang --- diff --git a/setting-common/include/setting-common-draw-widget.h b/setting-common/include/setting-common-draw-widget.h index 612d000..44f95e3 100755 --- a/setting-common/include/setting-common-draw-widget.h +++ b/setting-common/include/setting-common-draw-widget.h @@ -63,29 +63,6 @@ extern const Elm_Genlist_Item_Class itc_editfield; extern const Elm_Genlist_Item_Class itc_multiline_2text; extern const Elm_Genlist_Item_Class itc_1text_1icon_divider; -/*//TODO: Remove this */ -#define ADD_GL_HELP(scroller, str) \ - {\ - if (str) {\ - Setting_GenGroupItem_Data *item_data = \ - setting_create_Gendial_field_def(\ - scroller, &itc_multiline_text,\ - NULL,\ - NULL,\ - SWALLOW_Type_LAYOUT_SPECIALIZATION_X,\ - NULL, NULL, 0, str, NULL, NULL);\ - setting_retvm_if(NULL == item_data, -1, \ - "item_data is NULL");\ - elm_genlist_item_select_mode_set(item_data->item, \ - ELM_OBJECT_SELECT_MODE_DISPLAY_ONLY);\ - } \ - } - -#define _P(pEvasObj) do { \ - evas_object_event_callback_add(pEvasObj, EVAS_CALLBACK_DEL, \ - setting_protect_cb, &(pEvasObj));\ - } while (0); - /** * Do process when clicking radio in subitem of expandable item */ diff --git a/setting-display/src/setting-display-main.c b/setting-display/src/setting-display-main.c index e64cc1d..4179f84 100755 --- a/setting-display/src/setting-display-main.c +++ b/setting-display/src/setting-display-main.c @@ -163,7 +163,9 @@ static void setting_display_screen_timeout_popup(void *data) ad->screen_timeout_popup = setting_create_popup_with_list( &menu_glist, ad, ad->md.window, KeyStr_BacklightTime, NULL, 0, false, false, 0); - _P(ad->screen_timeout_popup); + if(ad->screen_timeout_popup) + evas_object_event_callback_add(ad->screen_timeout_popup, + EVAS_CALLBACK_DEL, setting_protect_cb, &(ad->screen_timeout_popup)); rdg = elm_radio_add(menu_glist); elm_object_style_set(rdg, "list"); diff --git a/setting-language-and-input/include/setting-language-and-input.h b/setting-language-and-input/include/setting-language-and-input.h index 6b920f5..92a9ce3 100755 --- a/setting-language-and-input/include/setting-language-and-input.h +++ b/setting-language-and-input/include/setting-language-and-input.h @@ -104,7 +104,6 @@ struct _SettingLanguageInputDataStruct { Setting_GenGroupItem_Data *data_keyboard; Setting_GenGroupItem_Data *data_voice_recog; Setting_GenGroupItem_Data *data_text_speech; - Setting_GenGroupItem_Data *data_readout; Setting_GenGroupItem_Data *data_title_keyboard; Setting_GenGroupItem_Data *data_title_speech; diff --git a/setting-language-and-input/src/setting-language-and-input-view.c b/setting-language-and-input/src/setting-language-and-input-view.c index bc08b77..6c1c235 100755 --- a/setting-language-and-input/src/setting-language-and-input-view.c +++ b/setting-language-and-input/src/setting-language-and-input-view.c @@ -390,16 +390,7 @@ static int _view_update(void *cb) ad->data_title_speech); elm_genlist_item_update(ad->data_title_speech->item); } - if (ad->data_readout) { - G_FREE(ad->data_readout->sub_desc); - /* TODO: no get_pa_noti_readout_str() function definition - ad->data_readout->sub_desc = get_pa_noti_readout_str(); - */ - ad->data_readout->sub_desc = "no description"; - elm_object_item_data_set(ad->data_readout->item, - ad->data_readout); - elm_genlist_item_update(ad->data_readout->item); - } + return SETTING_RETURN_SUCCESS; } diff --git a/setting-reset/src/setting-reset-main.c b/setting-reset/src/setting-reset-main.c index ec05fd0..e94bd5e 100644 --- a/setting-reset/src/setting-reset-main.c +++ b/setting-reset/src/setting-reset-main.c @@ -49,9 +49,8 @@ static Elm_Genlist_Item_Class itc; #define __DEV_OPT #ifndef __DEV_OPT - const static struct item items[] = { - //TODO add i18n to display_title fields + #if 0 { "Reset settings", setting_reset_settings_clicked, NULL}, { "Reset network settings", setting_reset_network_clicked, NULL}, diff --git a/setting-ringtone/src/setting-ringtone-main.c b/setting-ringtone/src/setting-ringtone-main.c index cc0e3ec..bf39fa4 100755 --- a/setting-ringtone/src/setting-ringtone-main.c +++ b/setting-ringtone/src/setting-ringtone-main.c @@ -516,9 +516,6 @@ static void _append_default_ringtones(SettingRingtoneData *ad) int ret = 0; bool append_custom_dir = false; - /*TODO: think about changing VCONFKEY_SETAPPL_CALL_RINGTONE_PATH_STR - to something which goes along with app_get_shared_resource_path()*/ - /* Get the default file list first. */ if (ad->show_notification) { ret = get_filelist_from_dir_path(ALERT_DIR_PATH, &ad->filelist); diff --git a/setting-storage/src/setting-storage-applications.c b/setting-storage/src/setting-storage-applications.c index 89b49d6..81c837e 100755 --- a/setting-storage/src/setting-storage-applications.c +++ b/setting-storage/src/setting-storage-applications.c @@ -905,7 +905,6 @@ static void _apps_delete_click_cb(void *data, Evas_Object *obj, void *event_info } if (ad->launched_by_external_app) { - /* TODO: add the code to handle external launch case: */ ui_app_exit(); return; }