From: Nick Clifton <nickc@redhat.com>
Date: Tue, 18 Jul 2017 14:46:13 +0000 (+0100)
Subject: Fix runtime failure triggered by a corrupt ecoff input file.
X-Git-Tag: users/ARM/embedded-binutils-master-2017q4~1607
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e4e21d9ed14c74304bc060a9d892c0edfc4c8ab4;p=external%2Fbinutils.git

Fix runtime failure triggered by a corrupt ecoff input file.

	PR binutils/21781
	* coffcode.h (handle_COMDAT): Replace abort with an error message
	and return.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index a439c16..f9eb98f 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2017-07-18  Nick Clifton  <nickc@redhat.com>
+
+	PR binutils/21781
+	* coffcode.h (handle_COMDAT): Replace abort with an error message
+	and return.
+
 2017-07-17  H.J. Lu  <hongjiu.lu@intel.com>
 
 	PR ld/21782
diff --git a/bfd/coffcode.h b/bfd/coffcode.h
index 898327b..21308de 100644
--- a/bfd/coffcode.h
+++ b/bfd/coffcode.h
@@ -997,7 +997,13 @@ handle_COMDAT (bfd * abfd,
 			|| isym.n_sclass == C_EXT)
 		       && BTYPE (isym.n_type) == T_NULL
 		       && isym.n_value == 0))
-		  abort ();
+		  {
+		    /* Malformed input files can trigger this test.
+		       cf PR 21781.  */
+		    _bfd_error_handler (_("%B: error: unexpected symbol '%s' in COMDAT section"),
+					abfd, symname);
+		    goto breakloop;
+		  }
 
 		/* FIXME LATER: MSVC generates section names
 		   like .text for comdats.  Gas generates