From: Dan Carpenter <error27@gmail.com>
Date: Sat, 29 Jan 2011 00:03:31 +0000 (-0800)
Subject: [SCSI] libfc:prevent  dereferencing ERR_PTR in fc_tm_done()
X-Git-Tag: v3.0~1550^2~123
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e4a9a98289606392f2b1b24b4ca4e29154ec4d15;p=platform%2Fkernel%2Flinux-amlogic.git

[SCSI] libfc:prevent  dereferencing ERR_PTR in fc_tm_done()

If we goto out, then it tries to call kfree_skb() on an ERR_PTR which
will oops.  Just return directly.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
---

diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c
index ba639fa..f4eb1ab 100644
--- a/drivers/scsi/libfc/fc_fcp.c
+++ b/drivers/scsi/libfc/fc_fcp.c
@@ -1323,7 +1323,7 @@ static void fc_tm_done(struct fc_seq *seq, struct fc_frame *fp, void *arg)
 		 *
 		 * scsi-eh will escalate for when either happens.
 		 */
-		goto out;
+		return;
 	}
 
 	if (fc_fcp_lock_pkt(fsp))