From: Patrik Flykt <patrik.flykt@linux.intel.com>
Date: Mon, 28 Jan 2013 15:44:43 +0000 (+0200)
Subject: service: Must not return NULL with a synchronous GDBus method call
X-Git-Tag: 1.11~9
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e49cb1f4dedfba7e6dc465ebdf46716b497587fb;p=platform%2Fupstream%2Fconnman.git

service: Must not return NULL with a synchronous GDBus method call

If NULL is returned, GDBus will call the registered function repeatedly.
---

diff --git a/src/service.c b/src/service.c
index 1e7cec7..a1d4a2f 100644
--- a/src/service.c
+++ b/src/service.c
@@ -3765,8 +3765,6 @@ static DBusMessage *disconnect_service(DBusConnection *conn,
 	if (err < 0) {
 		if (err != -EINPROGRESS)
 			return __connman_error_failed(msg, -err);
-
-		return NULL;
 	}
 
 	return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);