From: Behdad Esfahbod <behdad@behdad.org>
Date: Tue, 2 Mar 2010 03:33:45 +0000 (-0500)
Subject: [ft] Check stream->read instead of stream->base
X-Git-Tag: 2.0_alpha~7^2~868
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e48ed72230a83499dabbd02af2ac63340220a353;p=apps%2Fcore%2Fpreloaded%2Fvideo-player.git

[ft] Check stream->read instead of stream->base

The former is more robust.  See discussion on freetype-devel.
---

diff --git a/src/hb-ft.c b/src/hb-ft.c
index 4c508a2..fb8e566 100644
--- a/src/hb-ft.c
+++ b/src/hb-ft.c
@@ -164,12 +164,13 @@ hb_ft_face_create (FT_Face           ft_face,
 {
   hb_face_t *face;
 
-  /* TODO: Handle NULL ft_face (in other places too */
-  if (ft_face->stream->base != NULL) {
+  /* TODO: Handle NULL ft_face (in other places too) */
+  if (ft_face->stream->read == NULL) {
     hb_blob_t *blob;
 
     blob = hb_blob_create ((const char *) ft_face->stream->base,
 			   (unsigned int) ft_face->stream->size,
+			   /* TODO: Check FT_FACE_FLAG_EXTERNAL_STREAM? */
 			   HB_MEMORY_MODE_READONLY_MAY_MAKE_WRITABLE,
 			   destroy, ft_face);
     face = hb_face_create_for_data (blob, ft_face->face_index);