From: Colin Ian King <colin.king@canonical.com>
Date: Fri, 16 Apr 2021 12:43:52 +0000 (+0100)
Subject: PM: wakeup: remove redundant assignment to variable retval
X-Git-Tag: accepted/tizen/unified/20230118.172025~7397^2~3^4
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e48802333acecfa3ada7b13eb55fa03b08df9e74;p=platform%2Fkernel%2Flinux-rpi.git

PM: wakeup: remove redundant assignment to variable retval

The variable retval is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

diff --git a/drivers/base/power/wakeup_stats.c b/drivers/base/power/wakeup_stats.c
index 5ade753..924fac4 100644
--- a/drivers/base/power/wakeup_stats.c
+++ b/drivers/base/power/wakeup_stats.c
@@ -137,7 +137,7 @@ static struct device *wakeup_source_device_create(struct device *parent,
 						  struct wakeup_source *ws)
 {
 	struct device *dev = NULL;
-	int retval = -ENODEV;
+	int retval;
 
 	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
 	if (!dev) {