From: Fengguang Wu <fengguang.wu@intel.com>
Date: Mon, 30 Jul 2012 21:39:54 +0000 (-0700)
Subject: clk: validate pointer in __clk_disable()
X-Git-Tag: v3.12-rc1~2623^2~105
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e47c6a3408ea6bcfc5204f23d5a5b209de6e68b9;p=kernel%2Fkernel-generic.git

clk: validate pointer in __clk_disable()

clk_get() returns -ENOENT on error and some careless caller might
dereference it without error checking:

In mxc_rnga_remove():

        struct clk *clk = clk_get(&pdev->dev, "rng");

	// ...

        clk_disable(clk);

Since it's insane to audit the lots of existing and future clk users,
let's add a check in the callee to avoid kernel panic and warn about
any buggy user.

Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Viresh Kumar <viresh.kumar@st.com>
Cc: viresh kumar <viresh.linux@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index c87fdd7..efdfd00 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -465,6 +465,9 @@ static void __clk_disable(struct clk *clk)
 	if (!clk)
 		return;
 
+	if (WARN_ON(IS_ERR(clk)))
+		return;
+
 	if (WARN_ON(clk->enable_count == 0))
 		return;