From: Anton Blanchard Date: Wed, 3 Feb 2010 13:12:51 +0000 (+0000) Subject: ixgbe: Fix ixgbe_tx_map error path X-Git-Tag: v2.6.33-rc8~34^2~16 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e44d38e1b72a2aa7f5e7024c5da83a879355a1cc;p=platform%2Fupstream%2Fkernel-adaptation-pc.git ixgbe: Fix ixgbe_tx_map error path Commit e5a43549f7a58509a91b299a51337d386697b92c (ixgbe: remove skb_dma_map/unmap calls from driver) looks to have introduced a bug in ixgbe_tx_map. If we get an error from a PCI DMA call, we loop backwards through count until it becomes -1 and return that. The caller of ixgbe_tx_map expects 0 on error, so return that instead. Signed-off-by: Anton Blanchard Signed-off-by: Jeff Kirsher Signed-off-by: David S. Miller --- diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index b5f64ad..37e2af0 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c @@ -5179,7 +5179,7 @@ dma_error: ixgbe_unmap_and_free_tx_resource(adapter, tx_buffer_info); } - return count; + return 0; } static void ixgbe_tx_queue(struct ixgbe_adapter *adapter,