From: Lad Prabhakar Date: Mon, 10 Jan 2022 09:47:10 +0000 (+0000) Subject: ASoC: sh: rz-ssi: Make return type of rz_ssi_stream_is_valid() to bool X-Git-Tag: v6.6.17~6759^2~120^2~193^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e42c903e8bf400728c4ae1f922169b4d28b72efa;p=platform%2Fkernel%2Flinux-rpi.git ASoC: sh: rz-ssi: Make return type of rz_ssi_stream_is_valid() to bool rz_ssi_stream_is_valid() never returns an int, it returns the result of a condition which is either true or false. While at it, drop "!!" as the expression is boolean. Reported-by: Pavel Machek Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das Link: https://lore.kernel.org/r/20220110094711.8574-5-prabhakar.mahadev-lad.rj@bp.renesas.com Signed-off-by: Mark Brown --- diff --git a/sound/soc/sh/rz-ssi.c b/sound/soc/sh/rz-ssi.c index cbd8e1f3ac2e..81e1786b827d 100644 --- a/sound/soc/sh/rz-ssi.c +++ b/sound/soc/sh/rz-ssi.c @@ -188,14 +188,14 @@ static inline bool rz_ssi_is_dma_enabled(struct rz_ssi_priv *ssi) return (ssi->playback.dma_ch && (ssi->dma_rt || ssi->capture.dma_ch)); } -static int rz_ssi_stream_is_valid(struct rz_ssi_priv *ssi, - struct rz_ssi_stream *strm) +static bool rz_ssi_stream_is_valid(struct rz_ssi_priv *ssi, + struct rz_ssi_stream *strm) { unsigned long flags; - int ret; + bool ret; spin_lock_irqsave(&ssi->lock, flags); - ret = !!(strm->substream && strm->substream->runtime); + ret = strm->substream && strm->substream->runtime; spin_unlock_irqrestore(&ssi->lock, flags); return ret;