From: Craig Topper Date: Thu, 24 May 2012 04:22:05 +0000 (+0000) Subject: Mark a couple arrays as static and const. Use array_lengthof instead of sizeof/sizeof. X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e4260f911b80d3047b6ce949b58b5f93cf143951;p=platform%2Fupstream%2Fllvm.git Mark a couple arrays as static and const. Use array_lengthof instead of sizeof/sizeof. llvm-svn: 157369 --- diff --git a/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp b/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp index f268b4a..c2eb894 100644 --- a/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp +++ b/llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp @@ -490,7 +490,7 @@ NVPTXAsmPrinter::emitVirtualRegister(unsigned int vr, bool isVec, void NVPTXAsmPrinter::printVecModifiedImmediate(const MachineOperand &MO, const char *Modifier, raw_ostream &O) { -char vecelem[] = {'0', '1', '2', '3', '0', '1', '2', '3'}; + static const char vecelem[] = {'0', '1', '2', '3', '0', '1', '2', '3'}; int Imm = (int)MO.getImm(); if(0 == strcmp(Modifier, "vecelem")) O << "_" << vecelem[Imm]; diff --git a/llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp b/llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp index d326805..d517e81 100644 --- a/llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp +++ b/llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp @@ -887,10 +887,10 @@ NVPTXTargetLowering::getParamHelpSymbol(SelectionDAG &DAG, int idx) { // Check to see if the kernel argument is image*_t or sampler_t bool llvm::isImageOrSamplerVal(const Value *arg, const Module *context) { - const char *specialTypes[] = { - "struct._image2d_t", - "struct._image3d_t", - "struct._sampler_t" + static const char *const specialTypes[] = { + "struct._image2d_t", + "struct._image3d_t", + "struct._sampler_t" }; const Type *Ty = arg->getType(); @@ -905,7 +905,7 @@ bool llvm::isImageOrSamplerVal(const Value *arg, const Module *context) { const StructType *STy = dyn_cast(PTy->getElementType()); const std::string TypeName = STy ? STy->getName() : ""; - for (int i=0, e=sizeof(specialTypes)/sizeof(specialTypes[0]); i!=e; ++i) + for (int i = 0, e = array_lengthof(specialTypes); i != e; ++i) if (TypeName == specialTypes[i]) return true;