From: Pavel Labath Date: Tue, 24 Oct 2017 16:07:50 +0000 (+0000) Subject: Revert "[lldbtests] Handle errors instead of crashing." X-Git-Tag: llvmorg-6.0.0-rc1~5044 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e3f6eb1a74cb23dd7872a613cb79fd7e40b2270b;p=platform%2Fupstream%2Fllvm.git Revert "[lldbtests] Handle errors instead of crashing." The commit breaks the case where you specify just a filename to the compiler. Previously, it would look up the compiler in your path, now it complains that the compiler is not found. One of the lldb buildbots is depending on this. It seems like a nice feature to have, as it means less typing and being able to avoid hard-coding the system compiler path in the bot config. This reverts commit r316393. llvm-svn: 316451 --- diff --git a/lldb/packages/Python/lldbsuite/test/dotest.py b/lldb/packages/Python/lldbsuite/test/dotest.py index 91f1427..7d739ac 100644 --- a/lldb/packages/Python/lldbsuite/test/dotest.py +++ b/lldb/packages/Python/lldbsuite/test/dotest.py @@ -50,11 +50,7 @@ from ..support import seven def is_exe(fpath): - """Returns true if fpath is an executable. - Exits with an error code if the specified path is invalid""" - if not os.path.exists(fpath): - print(fpath + " is not a valid path, exiting") - sys.exit(-1) + """Returns true if fpath is an executable.""" return os.path.isfile(fpath) and os.access(fpath, os.X_OK)