From: Stephen Warren Date: Mon, 31 Mar 2014 18:25:24 +0000 (-0600) Subject: ASoC: alc5632: fix uninit var in alc5632_probe() X-Git-Tag: accepted/tizen/common/20141203.182822~239^2~1^2~1^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e3efe3bedb6592465d9a2bd116d5e611dae362c3;p=platform%2Fkernel%2Flinux-arm64.git ASoC: alc5632: fix uninit var in alc5632_probe() alc5632_probe() returns ret, yet it is not initialized or set anywhere. This ends up causing the function to appear to fail, and audio not to work on the Toshiba AC100, with my compiler at least. This function used to set ret in all cases, but recent cleanup removed that. Fixes: 5d6be5aa6bec ("ASoC: codec: Simplify ASoC probe code.") Signed-off-by: Stephen Warren Reviewed-by: Thierry Reding Signed-off-by: Mark Brown --- diff --git a/sound/soc/codecs/alc5632.c b/sound/soc/codecs/alc5632.c index ec071a6..3ee8d4e 100644 --- a/sound/soc/codecs/alc5632.c +++ b/sound/soc/codecs/alc5632.c @@ -1061,7 +1061,6 @@ static int alc5632_resume(struct snd_soc_codec *codec) static int alc5632_probe(struct snd_soc_codec *codec) { struct alc5632_priv *alc5632 = snd_soc_codec_get_drvdata(codec); - int ret; /* power on device */ alc5632_set_bias_level(codec, SND_SOC_BIAS_STANDBY); @@ -1075,7 +1074,7 @@ static int alc5632_probe(struct snd_soc_codec *codec) return -EINVAL; } - return ret; + return 0; } /* power down chip */