From: Gustavo A. R. Silva Date: Fri, 7 Jul 2017 05:36:10 +0000 (-0500) Subject: regulator: qcom_smd: add NULL check on of_match_device() return value X-Git-Tag: v5.15~10529^2^2~1^6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e3b53b8a465133ce57f9722aab5617b8e0f9657f;p=platform%2Fkernel%2Flinux-starfive.git regulator: qcom_smd: add NULL check on of_match_device() return value Check return value from call to of_match_device() in order to prevent a NULL pointer dereference. In case of NULL print error message and return. Signed-off-by: Gustavo A. R. Silva Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c index f35994a..940fe1b 100644 --- a/drivers/regulator/qcom_smd-regulator.c +++ b/drivers/regulator/qcom_smd-regulator.c @@ -570,6 +570,11 @@ static int rpm_reg_probe(struct platform_device *pdev) } match = of_match_device(rpm_of_match, &pdev->dev); + if (!match) { + dev_err(&pdev->dev, "failed to match device\n"); + return -ENODEV; + } + for (reg = match->data; reg->name; reg++) { vreg = devm_kzalloc(&pdev->dev, sizeof(*vreg), GFP_KERNEL); if (!vreg)