From: Stephane Delcroix Date: Wed, 21 Nov 2018 07:31:33 +0000 (+0100) Subject: [iOS] ScrollViewRenderer: clear the renderer (#4489) X-Git-Tag: accepted/tizen/5.5/unified/20200421.150457~655 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e38776cdeca4caae6d87ad3649f345700301b203;p=platform%2Fcore%2Fcsapi%2Fxsf.git [iOS] ScrollViewRenderer: clear the renderer (#4489) On Dispose(), the Renderer is supposed to be cleared on the element. That's taken care of by VisualElementRenderer`1.Dispose(). Unfortunately, ScrollViewRenderer doesn't inherit from it. I find it strange that this never was triggered before the Shell, but I'm learning to live surrounded by strange behaviors. -fixes #4381 --- diff --git a/Xamarin.Forms.Platform.iOS/Renderers/ScrollViewRenderer.cs b/Xamarin.Forms.Platform.iOS/Renderers/ScrollViewRenderer.cs index 31bab55..47281d0 100644 --- a/Xamarin.Forms.Platform.iOS/Renderers/ScrollViewRenderer.cs +++ b/Xamarin.Forms.Platform.iOS/Renderers/ScrollViewRenderer.cs @@ -160,6 +160,7 @@ namespace Xamarin.Forms.Platform.iOS if (_packager == null) return; + Element?.ClearValue(Platform.RendererProperty); SetElement(null); _packager.Dispose();