From: Mike Blumenkrantz <zmike@samsung.com>
Date: Wed, 29 May 2019 13:17:00 +0000 (-0400)
Subject: elm/colorselector: return early from theme apply if object is not yet finalized
X-Git-Tag: accepted/tizen/unified/20190604.014647~87
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e367b32c3e3728dab1eddba30bafde1b7ab4d090;p=platform%2Fupstream%2Fefl.git

elm/colorselector: return early from theme apply if object is not yet finalized

Summary:
the remainder of this function cannot be handled until objects are set up
later in construction

@fix
Depends on D8955

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8956
---

diff --git a/src/lib/elementary/elm_colorselector.c b/src/lib/elementary/elm_colorselector.c
index 6a9d742..1ad39c1 100644
--- a/src/lib/elementary/elm_colorselector.c
+++ b/src/lib/elementary/elm_colorselector.c
@@ -1375,6 +1375,9 @@ _elm_colorselector_efl_ui_widget_theme_apply(Eo *obj, Elm_Colorselector_Data *sd
    int_ret = efl_ui_widget_theme_apply(efl_super(obj, MY_CLASS));
    if (int_ret == EFL_UI_THEME_APPLY_ERROR_GENERIC) return int_ret;
 
+   /* none of the below objects are created before finalize */
+   if (!efl_finalized_get(obj)) return int_ret;
+
    if ((sd->mode == ELM_COLORSELECTOR_PALETTE) ||
        (sd->mode == ELM_COLORSELECTOR_ALL) ||
        (sd->mode == ELM_COLORSELECTOR_BOTH))