From: Takashi Sakamoto Date: Mon, 25 Jan 2021 14:02:08 +0000 (+0900) Subject: ALSA: bebob: remove an unnecessary condition in hwdep_read() X-Git-Tag: accepted/tizen/unified/20230118.172025~7834^2~3^2~33 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e32da5eb627c9dd60fd245cb5beb3079e96890d1;p=platform%2Fkernel%2Flinux-rpi.git ALSA: bebob: remove an unnecessary condition in hwdep_read() Drivers in ALSA firewire stack supports eventing to userspace applications via ALSA hwdep interface. All of the drivers supports stream lock events. Some of them supports their unique events according to specification of target device. ALSA bebob driver supports the stream lock event only. In the case, it's enough to check condition only in loop with process blocking. However, current implementation check it again after breaking the loop. This commit removes the redundant check. Reported-by: Dan Carpenter Reported-by: Christophe JAILLET Signed-off-by: Takashi Sakamoto Link: https://lore.kernel.org/r/20210125140208.26318-1-o-takashi@sakamocchi.jp Signed-off-by: Takashi Iwai --- diff --git a/sound/firewire/bebob/bebob_hwdep.c b/sound/firewire/bebob/bebob_hwdep.c index 8677e3e..6f93316 100644 --- a/sound/firewire/bebob/bebob_hwdep.c +++ b/sound/firewire/bebob/bebob_hwdep.c @@ -37,11 +37,9 @@ hwdep_read(struct snd_hwdep *hwdep, char __user *buf, long count, memset(&event, 0, sizeof(event)); count = min_t(long, count, sizeof(event.lock_status)); - if (bebob->dev_lock_changed) { - event.lock_status.type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS; - event.lock_status.status = (bebob->dev_lock_count > 0); - bebob->dev_lock_changed = false; - } + event.lock_status.type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS; + event.lock_status.status = (bebob->dev_lock_count > 0); + bebob->dev_lock_changed = false; spin_unlock_irq(&bebob->lock);