From: Daniel Juyung Seo Date: Thu, 2 Jan 2014 00:11:25 +0000 (+0900) Subject: image: Remove unnecessary parameter for elm_obj_image_editable_set. X-Git-Tag: v1.9.0-alpha1~310 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e3107621027c0dc32aed58c884c95cd389632585;p=platform%2Fupstream%2Felementary.git image: Remove unnecessary parameter for elm_obj_image_editable_set. This parameter was introduced as an internal funciton parameter long ago and migrated to eo as it was. But this parameter is not needed. obj pointer is already there. Thanks to Yakov for the report. --- diff --git a/src/lib/elm_image.c b/src/lib/elm_image.c index 981b834..79d1b71 100644 --- a/src/lib/elm_image.c +++ b/src/lib/elm_image.c @@ -1461,7 +1461,7 @@ elm_image_editable_set(Evas_Object *obj, Eina_Bool set) { ELM_IMAGE_CHECK(obj); - eo_do(obj, elm_obj_image_editable_set(set, obj)); + eo_do(obj, elm_obj_image_editable_set(set)); } /** @@ -1473,7 +1473,6 @@ _elm_image_smart_editable_set(Eo *obj, void *_pd, va_list *list) { Elm_Image_Smart_Data *sd = _pd; Eina_Bool edit = va_arg(*list, int); - Evas_Object *parent = va_arg(*list, Evas_Object *); if (sd->edje) { @@ -1493,14 +1492,14 @@ _elm_image_smart_editable_set(Eo *obj, void *_pd, va_list *list) NULL, NULL, NULL, NULL, NULL, NULL, - _elm_image_drag_n_drop_cb, parent); + _elm_image_drag_n_drop_cb, obj); else elm_drop_target_del (obj, ELM_SEL_FORMAT_IMAGE, NULL, NULL, NULL, NULL, NULL, NULL, - _elm_image_drag_n_drop_cb, parent); + _elm_image_drag_n_drop_cb, obj); } EAPI Eina_Bool diff --git a/src/lib/elm_image_eo.h b/src/lib/elm_image_eo.h index f65812f..4a5358a 100644 --- a/src/lib/elm_image_eo.h +++ b/src/lib/elm_image_eo.h @@ -289,11 +289,10 @@ enum * Make the image 'editable'. * * @param[in] set - * @param[in] parent * * @see elm_image_editable_set */ -#define elm_obj_image_editable_set(set, parent) ELM_OBJ_IMAGE_ID(ELM_OBJ_IMAGE_SUB_ID_EDITABLE_SET), EO_TYPECHECK(Eina_Bool, set), EO_TYPECHECK(Evas_Object *, parent) +#define elm_obj_image_editable_set(set) ELM_OBJ_IMAGE_ID(ELM_OBJ_IMAGE_SUB_ID_EDITABLE_SET), EO_TYPECHECK(Eina_Bool, set) /** * @def elm_obj_image_editable_get