From: Takashi Sakamoto Date: Tue, 3 Jan 2017 02:58:32 +0000 (+0900) Subject: ALSA: fireworks: fix asymmetric API call at unit removal X-Git-Tag: v4.14-rc1~1711^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e2eb31d72156c58b717396383496a7c93aa01b75;p=platform%2Fkernel%2Flinux-rpi.git ALSA: fireworks: fix asymmetric API call at unit removal ALSA fireworks driver has a bug not to call an API to destroy 'cmp_connection' structure for input direction. Currently this causes no issues because it just destroys 'mutex' structure, while it's better to fix it for future work. Fix: d23c2cc4485d ("ALSA: fireworks/bebob/dice/oxfw: allow stream destructor after releasing runtime") Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai --- diff --git a/sound/firewire/fireworks/fireworks_stream.c b/sound/firewire/fireworks/fireworks_stream.c index ee47924..827161b 100644 --- a/sound/firewire/fireworks/fireworks_stream.c +++ b/sound/firewire/fireworks/fireworks_stream.c @@ -117,7 +117,7 @@ destroy_stream(struct snd_efw *efw, struct amdtp_stream *stream) conn = &efw->in_conn; amdtp_stream_destroy(stream); - cmp_connection_destroy(&efw->out_conn); + cmp_connection_destroy(conn); } static int