From: hj kim <backto.kim@samsung.com>
Date: Thu, 11 Mar 2021 02:26:18 +0000 (+0900)
Subject: webrtc : minor code changes
X-Git-Tag: submit/tizen/20210729.023123~116
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e2cf3015efca6d6555ce707e5ba56f14543126c8;p=platform%2Fcore%2Fapi%2Fwebrtc.git

webrtc : minor code changes

1. return error directly.
2. Add build option for test codes.

[Version] 0.1.125
[Issue Type] Improvement

Change-Id: I8f4fc393d7adf0d658eadef0e40b1346794dd618
---

diff --git a/packaging/capi-media-webrtc.spec b/packaging/capi-media-webrtc.spec
index 8647d3a4..1451356e 100644
--- a/packaging/capi-media-webrtc.spec
+++ b/packaging/capi-media-webrtc.spec
@@ -1,6 +1,6 @@
 Name:       capi-media-webrtc
 Summary:    A WebRTC library in Tizen Native API
-Version:    0.1.124
+Version:    0.1.125
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
diff --git a/src/webrtc.c b/src/webrtc.c
index 84e945e1..031fec4a 100644
--- a/src/webrtc.c
+++ b/src/webrtc.c
@@ -113,7 +113,9 @@ int webrtc_unset_state_changed_cb(webrtc_h webrtc)
 
 int webrtc_create(webrtc_h *webrtc)
 {
+#ifdef TIZEN_FEATURE_RES_MGR
 	int ret = WEBRTC_ERROR_NONE;
+#endif
 	webrtc_s *_webrtc = NULL;
 
 	RET_ERR_IF_NETWORK_FEATURES_ARE_NOT_SUPPORTED();
@@ -150,7 +152,7 @@ int webrtc_create(webrtc_h *webrtc)
 
 	g_mutex_unlock(&_webrtc->mutex);
 
-	return ret;
+	return WEBRTC_ERROR_NONE;
 }
 
 int webrtc_destroy(webrtc_h webrtc)
@@ -218,7 +220,7 @@ int webrtc_start(webrtc_h webrtc)
 
 	g_mutex_unlock(&_webrtc->mutex);
 
-	return ret;
+	return WEBRTC_ERROR_NONE;
 }
 
 int webrtc_stop(webrtc_h webrtc)
@@ -855,13 +857,9 @@ int webrtc_create_data_channel(webrtc_h webrtc, const char *label, webrtc_data_c
 
 int webrtc_destroy_data_channel(webrtc_data_channel_h channel)
 {
-	int ret = WEBRTC_ERROR_NONE;
-
 	RET_VAL_IF(channel == NULL, WEBRTC_ERROR_INVALID_PARAMETER, "channel is NULL");
 
-	ret = _destroy_data_channel((webrtc_data_channel_s *)channel);
-
-	return ret;
+	return _destroy_data_channel((webrtc_data_channel_s *)channel);
 }
 
 int webrtc_set_data_channel_cb(webrtc_h webrtc, webrtc_data_channel_cb callback, void *user_data)
diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
index 9d92b8d4..35a27839 100644
--- a/test/CMakeLists.txt
+++ b/test/CMakeLists.txt
@@ -11,7 +11,7 @@ FOREACH(flag ${${fw_test}_CFLAGS})
     SET(EXTRA_CFLAGS "${EXTRA_CFLAGS} ${flag}")
 ENDFOREACH(flag)
 
-SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${EXTRA_CFLAGS} -pie")
+SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${EXTRA_CFLAGS} -pie -Wall -Werror")
 
 aux_source_directory(. sources)