From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Wed, 10 Nov 2010 11:21:43 +0000 (+0100)
Subject: crypto: pcrypt - Fix use after free on padata_free
X-Git-Tag: accepted/tizen/common/20141203.182822~9625
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e2b348354112df63a9c2ea4219a6867c6c7ea100;p=platform%2Fkernel%2Flinux-arm64.git

crypto: pcrypt - Fix use after free on padata_free

kobject_put is called from padata_free for the padata kobject.
The kobject's release function frees the padata instance,
so don't call kobject_put for the padata kobject from pcrypt.

Reported-and-tested-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/crypto/pcrypt.c b/crypto/pcrypt.c
index de30782..75586f1 100644
--- a/crypto/pcrypt.c
+++ b/crypto/pcrypt.c
@@ -504,7 +504,6 @@ err:
 
 static void pcrypt_fini_padata(struct padata_pcrypt *pcrypt)
 {
-	kobject_put(&pcrypt->pinst->kobj);
 	free_cpumask_var(pcrypt->cb_cpumask->mask);
 	kfree(pcrypt->cb_cpumask);