From: Cory Benfield <lukasaoz@gmail.com>
Date: Tue, 7 Jan 2014 09:37:59 +0000 (+0000)
Subject: Don't let proxy_bypass bring you down.
X-Git-Tag: v2.2.0~3^2^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e2a36dda0a4bd0b09d76fe6bf30e6fca4d2822ca;p=services%2Fpython-requests.git

Don't let proxy_bypass bring you down.
---

diff --git a/requests/utils.py b/requests/utils.py
index c7e2b08..e69e9a8 100644
--- a/requests/utils.py
+++ b/requests/utils.py
@@ -487,7 +487,16 @@ def get_environ_proxies(url):
 
     # If the system proxy settings indicate that this URL should be bypassed,
     # don't proxy.
-    if proxy_bypass(netloc):
+    # The proxy_bypass function is incredibly buggy on OS X in early versions
+    # of Python 2.6, so allow this call to fail. Only catch the specific
+    # exceptions we've seen, though: this call failing in other ways can reveal
+    # legitimate problems.
+    try:
+        bypass = proxy_bypass(netloc)
+    except (TypeError, socket.gaierror):
+        bypass = False
+
+    if bypass:
         return {}
 
     # If we get here, we either didn't have no_proxy set or we're not going