From: Bhuvan Arumugam Date: Mon, 27 Jan 2014 15:01:13 +0000 (+0530) Subject: fix for #237 X-Git-Tag: v0.2.23~51^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e27e19fd1fa8cf093387a2c098a478bbe4386501;p=tools%2Fpython-jenkinsapi.git fix for #237 When the first job for the job was deleted and there is only one job (latest?) in the build, get_job() API fail with TypeError. This commit fixes this issue. https://github.com/salimfadhley/jenkinsapi/issues/237 --- diff --git a/jenkinsapi/job.py b/jenkinsapi/job.py index 2abcbfc..49f4972 100644 --- a/jenkinsapi/job.py +++ b/jenkinsapi/job.py @@ -103,7 +103,10 @@ class Job(JenkinsBase, MutableJenkinsThing): return data # do not call _buildid_for_type here: it would poll and do an infinite loop oldest_loaded_build_number = data["builds"][-1]["number"] - first_build_number = data["firstBuild"]["number"] + if not data['firstBuild']: + first_build_number = oldest_loaded_build_number + else: + first_build_number = data["firstBuild"]["number"] all_builds_loaded = (oldest_loaded_build_number == first_build_number) if all_builds_loaded: return data