From: Carsten Haitzler (Rasterman) <raster@rasterman.com>
Date: Thu, 14 Aug 2014 09:52:31 +0000 (+0900)
Subject: eldbus - fix varargs missing end in iter get and next
X-Git-Tag: v1.11.0~66
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e263af08c9269eef66141fbca0e8a1a0cd6b8d2a;p=platform%2Fupstream%2Fefl.git

eldbus - fix varargs missing end in iter get and next

there was an error return handler that would return without doing
va_end(). coverity picked this up. this fixes CID 1039883
---

diff --git a/src/lib/eldbus/eldbus_message.c b/src/lib/eldbus/eldbus_message.c
index 1d1eeb8..aa44410 100644
--- a/src/lib/eldbus/eldbus_message.c
+++ b/src/lib/eldbus/eldbus_message.c
@@ -717,7 +717,11 @@ eldbus_message_iter_get_and_next(Eldbus_Message_Iter *iter, char signature, ...)
         Eldbus_Message_Iter **iter_var = va_arg(vl, Eldbus_Message_Iter**);
 
         sub = _message_iterator_new(EINA_FALSE);
-        EINA_SAFETY_ON_NULL_RETURN_VAL(sub, EINA_FALSE);
+        if (!sub)
+          {
+             va_end(vl);
+             return EINA_FALSE;
+          }
         dbus_message_iter_recurse(&iter->dbus_iterator,
                                   &sub->dbus_iterator);
         iter->iterators = eina_inlist_append(iter->iterators,