From: chanywa Date: Thu, 5 Jan 2017 05:12:24 +0000 (+0900) Subject: Remove unnecessary warning messages in logs X-Git-Tag: submit/trunk/20170823.075128~101^2~49 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e2637f30068bb70809591d5c8d6a5ed7899063b0;p=platform%2Fcore%2Fcsapi%2Ftizenfx.git Remove unnecessary warning messages in logs Change-Id: I4833e85f72cbd7b1ff13ce262065e2aa4faa8c3c --- diff --git a/src/Tizen.Maps/Tizen.Maps/Marker.cs b/src/Tizen.Maps/Tizen.Maps/Marker.cs index f12c728..e07a743 100755 --- a/src/Tizen.Maps/Tizen.Maps/Marker.cs +++ b/src/Tizen.Maps/Tizen.Maps/Marker.cs @@ -37,8 +37,6 @@ namespace Tizen.Maps } } - // TODO: Need to rename all Geocoordinates type property to Coordinates and all screen coordinates to Position - /// /// Geographical coordinates for marker /// diff --git a/src/Tizen.Maps/Tizen.Maps/Overlay.cs b/src/Tizen.Maps/Tizen.Maps/Overlay.cs index 1d73b00..fd4314f 100755 --- a/src/Tizen.Maps/Tizen.Maps/Overlay.cs +++ b/src/Tizen.Maps/Tizen.Maps/Overlay.cs @@ -46,7 +46,6 @@ namespace Tizen.Maps { err.ThrowIfFailed("given coordinates or parent evas object is null"); } - _containedObject = objectToContain; } diff --git a/src/Tizen.Maps/Tizen.Maps/Place.cs b/src/Tizen.Maps/Tizen.Maps/Place.cs index ded800b..8d8116c 100755 --- a/src/Tizen.Maps/Tizen.Maps/Place.cs +++ b/src/Tizen.Maps/Tizen.Maps/Place.cs @@ -49,22 +49,17 @@ namespace Tizen.Maps { handle = new Interop.PlaceHandle(nativeHandle); - var err = Interop.Place.GetDistance(handle, out _distance); - err.WarnIfFailed("Failed to get distance for this place"); + Interop.Place.GetDistance(handle, out _distance); IntPtr supplierHandle; - err = Interop.Place.GetSupplierLink(handle, out supplierHandle); - if (err.WarnIfFailed("Failed to get supplier link for this image")) - { + var err = Interop.Place.GetSupplierLink(handle, out supplierHandle); + if (err.IsSuccess()) _supplier = new PlaceLink(supplierHandle); - } IntPtr relatedHandle; err = Interop.Place.GetRelatedLink(handle, out relatedHandle); - if (err.WarnIfFailed("Failed to get related link for this image")) - { + if (err.IsSuccess()) _related = new PlaceLink(relatedHandle); - } } /// diff --git a/src/Tizen.Maps/Tizen.Maps/PlaceAttribute.cs b/src/Tizen.Maps/Tizen.Maps/PlaceAttribute.cs index 451f2a2..2a59920 100755 --- a/src/Tizen.Maps/Tizen.Maps/PlaceAttribute.cs +++ b/src/Tizen.Maps/Tizen.Maps/PlaceAttribute.cs @@ -30,14 +30,10 @@ namespace Tizen.Maps internal PlaceAttribute(IntPtr nativeHandle) { var handle = new Interop.PlaceAttributeHandle(nativeHandle); - var err = Interop.PlaceAttribute.GetId(handle, out _id); - err.WarnIfFailed("Failed to get id for this attribute"); - err = Interop.PlaceAttribute.GetLabel(handle, out _label); - err.WarnIfFailed("Failed to get label for this attribute"); - - err = Interop.PlaceAttribute.GetText(handle, out _text); - err.WarnIfFailed("Failed to get text for this attribute"); + Interop.PlaceAttribute.GetId(handle, out _id); + Interop.PlaceAttribute.GetLabel(handle, out _label); + Interop.PlaceAttribute.GetText(handle, out _text); } /// diff --git a/src/Tizen.Maps/Tizen.Maps/PlaceCategory.cs b/src/Tizen.Maps/Tizen.Maps/PlaceCategory.cs index 4659c18..a9a252a 100755 --- a/src/Tizen.Maps/Tizen.Maps/PlaceCategory.cs +++ b/src/Tizen.Maps/Tizen.Maps/PlaceCategory.cs @@ -106,14 +106,9 @@ namespace Tizen.Maps internal void Initialize() { - var err = Interop.PlaceCategory.GetId(handle, out _id); - err.WarnIfFailed("Failed to get id for place category"); - - err = Interop.PlaceCategory.GetName(handle, out _name); - err.WarnIfFailed("Failed to get name for place category"); - - err = Interop.PlaceCategory.GetUrl(handle, out _url); - err.WarnIfFailed("Failed to get URL for place category"); + Interop.PlaceCategory.GetId(handle, out _id); + Interop.PlaceCategory.GetName(handle, out _name); + Interop.PlaceCategory.GetUrl(handle, out _url); } } } diff --git a/src/Tizen.Maps/Tizen.Maps/PlaceContact.cs b/src/Tizen.Maps/Tizen.Maps/PlaceContact.cs index b3cf10f..6ff8f8a 100755 --- a/src/Tizen.Maps/Tizen.Maps/PlaceContact.cs +++ b/src/Tizen.Maps/Tizen.Maps/PlaceContact.cs @@ -31,14 +31,10 @@ namespace Tizen.Maps internal PlaceContact(IntPtr nativeHandle) { var handle = new Interop.PlaceContactHandle(nativeHandle); - var err = Interop.PlaceContact.GetLabel(handle, out _label); - err.WarnIfFailed("Failed to get label for this contact"); - err = Interop.PlaceContact.GetType(handle, out _type); - err.WarnIfFailed("Failed to get type for this contact"); - - err = Interop.PlaceContact.GetValue(handle, out _value); - err.WarnIfFailed("Failed to get value for this contact"); + Interop.PlaceContact.GetLabel(handle, out _label); + Interop.PlaceContact.GetType(handle, out _type); + Interop.PlaceContact.GetValue(handle, out _value); } /// diff --git a/src/Tizen.Maps/Tizen.Maps/PlaceEditorial.cs b/src/Tizen.Maps/Tizen.Maps/PlaceEditorial.cs index b77515e..f2bce58 100755 --- a/src/Tizen.Maps/Tizen.Maps/PlaceEditorial.cs +++ b/src/Tizen.Maps/Tizen.Maps/PlaceEditorial.cs @@ -30,18 +30,14 @@ namespace Tizen.Maps internal PlaceEditorial(IntPtr nativeHandle) { var handle = new Interop.PlaceEditorialHandle(nativeHandle); - var err = Interop.PlaceEditorial.GetDescription(handle, out _description); - err.WarnIfFailed("Failed to get description for this editorial"); - err = Interop.PlaceEditorial.GetLanguage(handle, out _language); - err.WarnIfFailed("Failed to get language for this editorial"); + Interop.PlaceEditorial.GetDescription(handle, out _description); + Interop.PlaceEditorial.GetLanguage(handle, out _language); IntPtr mediaHandle; - err = Interop.PlaceEditorial.GetMedia(handle, out mediaHandle); - if (err.WarnIfFailed("Failed to get media for this editorial")) - { + var err = Interop.PlaceEditorial.GetMedia(handle, out mediaHandle); + if (err.IsSuccess()) _media = new PlaceMedia(mediaHandle); - } } /// diff --git a/src/Tizen.Maps/Tizen.Maps/PlaceImage.cs b/src/Tizen.Maps/Tizen.Maps/PlaceImage.cs index 272bbdb..38fcb68 100755 --- a/src/Tizen.Maps/Tizen.Maps/PlaceImage.cs +++ b/src/Tizen.Maps/Tizen.Maps/PlaceImage.cs @@ -33,31 +33,21 @@ namespace Tizen.Maps internal PlaceImage(IntPtr nativeHandle) { var handle = new Interop.PlaceImageHandle(nativeHandle); - var err = Interop.PlaceImage.GetId(handle, out _id); - err.WarnIfFailed("Failed to get id for this image"); - err = Interop.PlaceImage.GetUrl(handle, out _url); - err.WarnIfFailed("Failed to get URL for this image"); - - err = Interop.PlaceImage.GetWidth(handle, out _width); - err.WarnIfFailed("Failed to get width for this image"); - - err = Interop.PlaceImage.GetHeight(handle, out _height); - err.WarnIfFailed("Failed to get height for this image"); + Interop.PlaceImage.GetId(handle, out _id); + Interop.PlaceImage.GetUrl(handle, out _url); + Interop.PlaceImage.GetWidth(handle, out _width); + Interop.PlaceImage.GetHeight(handle, out _height); IntPtr userHandle; - err = Interop.PlaceImage.GetUserLink(handle, out userHandle); - if (err.WarnIfFailed("Failed to get user link for this image")) - { + var err = Interop.PlaceImage.GetUserLink(handle, out userHandle); + if (err.IsSuccess()) _userLink = new PlaceLink(userHandle); - } IntPtr mediaHandle; err = Interop.PlaceImage.GetMedia(handle, out mediaHandle); - if (err.WarnIfFailed("Failed to get media for this image")) - { + if (err.IsSuccess()) _media = new PlaceMedia(mediaHandle); - } } /// diff --git a/src/Tizen.Maps/Tizen.Maps/PlaceLink.cs b/src/Tizen.Maps/Tizen.Maps/PlaceLink.cs index dade418..b2d262e 100755 --- a/src/Tizen.Maps/Tizen.Maps/PlaceLink.cs +++ b/src/Tizen.Maps/Tizen.Maps/PlaceLink.cs @@ -33,17 +33,10 @@ namespace Tizen.Maps { var handle = new Interop.PlaceLinkObjectHandle(nativeHandle); - var err = Interop.PlaceLinkObject.GetId(handle, out _id); - err.WarnIfFailed("Failed to get id for this link"); - - err = Interop.PlaceLinkObject.GetName(handle, out _name); - err.WarnIfFailed("Failed to get name for this link"); - - err = Interop.PlaceLinkObject.GetString(handle, out _string); - err.WarnIfFailed("Failed to get string for this link"); - - err = Interop.PlaceLinkObject.GetType(handle, out _type); - err.WarnIfFailed("Failed to get type for this link"); + Interop.PlaceLinkObject.GetId(handle, out _id); + Interop.PlaceLinkObject.GetName(handle, out _name); + Interop.PlaceLinkObject.GetString(handle, out _string); + Interop.PlaceLinkObject.GetType(handle, out _type); } /// diff --git a/src/Tizen.Maps/Tizen.Maps/PlaceList.cs b/src/Tizen.Maps/Tizen.Maps/PlaceList.cs index e92bd5d..68afb7b 100755 --- a/src/Tizen.Maps/Tizen.Maps/PlaceList.cs +++ b/src/Tizen.Maps/Tizen.Maps/PlaceList.cs @@ -36,8 +36,7 @@ namespace Tizen.Maps return true; }; - var err = Interop.Place.ListForeach(handle, callback, IntPtr.Zero); - err.WarnIfFailed("Failed to create address to the list from native handle"); + Interop.Place.ListForeach(handle, callback, IntPtr.Zero); } /// diff --git a/src/Tizen.Maps/Tizen.Maps/PlaceMedia.cs b/src/Tizen.Maps/Tizen.Maps/PlaceMedia.cs index 22a19ec..182ef6d 100755 --- a/src/Tizen.Maps/Tizen.Maps/PlaceMedia.cs +++ b/src/Tizen.Maps/Tizen.Maps/PlaceMedia.cs @@ -31,22 +31,17 @@ namespace Tizen.Maps { var handle = new Interop.PlaceMediaHandle(nativeHandle); - var err = Interop.PlaceMedia.GetAttribution(handle, out _attribution); - err.WarnIfFailed("Failed to get attribution for this media"); + Interop.PlaceMedia.GetAttribution(handle, out _attribution); IntPtr supplierHandle; - err = Interop.PlaceMedia.GetSupplier(handle, out supplierHandle); - if (err.WarnIfFailed("Failed to get supplier object for this media")) - { + var err = Interop.PlaceMedia.GetSupplier(handle, out supplierHandle); + if (err.IsSuccess()) _supplier = new PlaceLink(supplierHandle); - } IntPtr viaHandle; err = Interop.PlaceMedia.GetVia(handle, out viaHandle); - if (err.WarnIfFailed("Failed to get via object for this media")) - { + if (err.IsSuccess()) _via = new PlaceLink(viaHandle); - } } /// diff --git a/src/Tizen.Maps/Tizen.Maps/PlaceRating.cs b/src/Tizen.Maps/Tizen.Maps/PlaceRating.cs index 2d31e41..5ce78a2 100755 --- a/src/Tizen.Maps/Tizen.Maps/PlaceRating.cs +++ b/src/Tizen.Maps/Tizen.Maps/PlaceRating.cs @@ -30,11 +30,8 @@ namespace Tizen.Maps { var handle = new Interop.PlaceRatingHandle(nativeHandle); - var err = Interop.PlaceRating.GetCount(handle, out _count); - err.WarnIfFailed("Failed to get count value for this rating"); - - err = Interop.PlaceRating.GetAverage(handle, out _average); - err.WarnIfFailed("Failed to get average value for this rating"); + Interop.PlaceRating.GetCount(handle, out _count); + Interop.PlaceRating.GetAverage(handle, out _average); } /// diff --git a/src/Tizen.Maps/Tizen.Maps/PlaceReview.cs b/src/Tizen.Maps/Tizen.Maps/PlaceReview.cs index 6c1f163..8a794a0 100755 --- a/src/Tizen.Maps/Tizen.Maps/PlaceReview.cs +++ b/src/Tizen.Maps/Tizen.Maps/PlaceReview.cs @@ -33,10 +33,11 @@ namespace Tizen.Maps internal PlaceReview(IntPtr nativeHandle) { - string date; var handle = new Interop.PlaceReviewHandle(nativeHandle); + + string date; var err = Interop.PlaceReview.GetDate(handle, out date); - if (err.WarnIfFailed("Failed to get date for this review")) + if (err.IsSuccess()) { if (DateTime.TryParse(date, out _date) == false) { @@ -44,31 +45,20 @@ namespace Tizen.Maps } } - err = Interop.PlaceReview.GetTitle(handle, out _title); - err.WarnIfFailed("Failed to get title for this review"); - - err = Interop.PlaceReview.GetRating(handle, out _rating); - err.WarnIfFailed("Failed to get rating for this review"); - - err = Interop.PlaceReview.GetDescription(handle, out _description); - err.WarnIfFailed("Failed to get description for this review"); - - err = Interop.PlaceReview.GetLanguage(handle, out _language); - err.WarnIfFailed("Failed to get language for this review"); + Interop.PlaceReview.GetTitle(handle, out _title); + Interop.PlaceReview.GetRating(handle, out _rating); + Interop.PlaceReview.GetDescription(handle, out _description); + Interop.PlaceReview.GetLanguage(handle, out _language); IntPtr mediaHandle; err = Interop.PlaceReview.GetMedia(handle, out mediaHandle); - if (err.WarnIfFailed("Failed to get media for this review")) - { + if (err.IsSuccess()) _media = new PlaceMedia(mediaHandle); - } IntPtr userHandle; err = Interop.PlaceReview.GetUserLink(handle, out userHandle); - if (err.WarnIfFailed("Failed to get user link for this review")) - { + if (err.IsSuccess()) _userLink = new PlaceLink(userHandle); - } } /// diff --git a/src/Tizen.Maps/Tizen.Maps/PlaceSearchPreference.cs b/src/Tizen.Maps/Tizen.Maps/PlaceSearchPreference.cs index 8e8cd66..90558f9 100755 --- a/src/Tizen.Maps/Tizen.Maps/PlaceSearchPreference.cs +++ b/src/Tizen.Maps/Tizen.Maps/PlaceSearchPreference.cs @@ -39,7 +39,7 @@ namespace Tizen.Maps { IntPtr nativeHandle; var err = Interop.Preference.Create(out nativeHandle); - err.WarnIfFailed("Failed to create native preference handle"); + err.ThrowIfFailed("Failed to create native preference handle"); handle = new Interop.PreferenceHandle(nativeHandle); }