From: Derek Foreman <derekf@osg.samsung.com>
Date: Mon, 5 Jun 2017 21:22:08 +0000 (-0500)
Subject: ecore_drm2: Fix error handling in _output_dpms_atomic_set
X-Git-Tag: upstream/1.20.0~754
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e24670b1e2b720ea732517af1767214e41774779;p=platform%2Fupstream%2Fefl.git

ecore_drm2: Fix error handling in _output_dpms_atomic_set

This was skipping the error path on failure and setting some state as if
it was successful.  Then the next attempt at a page flip was actually
setting this state.

So _output_dpms_atomic_set (which has always been broken) wasn't actually
the function that successfully disabled dpms.

This is confounding attempts to debug why dpms isn't coming back on
properly.

Now it won't turn *off* either, because it really never should have.

Ref T5462
---

diff --git a/src/lib/ecore_drm2/ecore_drm2_outputs.c b/src/lib/ecore_drm2/ecore_drm2_outputs.c
index 39fb847..263fccd 100644
--- a/src/lib/ecore_drm2/ecore_drm2_outputs.c
+++ b/src/lib/ecore_drm2/ecore_drm2_outputs.c
@@ -450,6 +450,7 @@ _output_dpms_atomic_set(Ecore_Drm2_Output *output, int level)
      {
         ERR("Could not set dpms property: %m");
         ret = EINA_FALSE;
+        goto err;
      }
 
    cstate->dpms.value = level;