From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 5 Nov 2015 13:34:43 +0000 (+0100)
Subject: staging: most: Delete an unnecessary check before the function call "module_put"
X-Git-Tag: v4.14-rc1~4041^2~355
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e23afff94803e9735d4f0edda0c77efad8d408a4;p=platform%2Fkernel%2Flinux-rpi.git

staging: most: Delete an unnecessary check before the function call "module_put"

The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c
index 19852ca..ed1ed25 100644
--- a/drivers/staging/most/mostcore/core.c
+++ b/drivers/staging/most/mostcore/core.c
@@ -1587,8 +1587,7 @@ out:
 	return 0;
 
 error:
-	if (iface->mod)
-		module_put(iface->mod);
+	module_put(iface->mod);
 	modref--;
 	mutex_unlock(&c->start_mutex);
 	return ret;