From: Jukka Rissanen <jukka.rissanen@nokia.com>
Date: Fri, 31 Dec 2010 09:57:10 +0000 (+0200)
Subject: Possible memory leak when creating ipconfig
X-Git-Tag: 2.0_alpha~1931
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e21ce8488fd173b52fe3411ad589e3d5e49ca6e8;p=framework%2Fconnectivity%2Fconnman.git

Possible memory leak when creating ipconfig
---

diff --git a/src/service.c b/src/service.c
index befd026..c88e327 100644
--- a/src/service.c
+++ b/src/service.c
@@ -4329,7 +4329,8 @@ __connman_service_create_from_provider(struct connman_provider *provider)
 
 	service->strength = 0;
 
-	service->ipconfig_ipv4 = connman_ipconfig_create(index,
+	if (service->ipconfig_ipv4 == NULL)
+		service->ipconfig_ipv4 = connman_ipconfig_create(index,
 						CONNMAN_IPCONFIG_TYPE_IPV4);
 	if (service->ipconfig_ipv4 == NULL)
 		return service;
@@ -4339,7 +4340,8 @@ __connman_service_create_from_provider(struct connman_provider *provider)
 	connman_ipconfig_set_data(service->ipconfig_ipv4, service);
 	connman_ipconfig_set_ops(service->ipconfig_ipv4, &service_ops);
 
-	service->ipconfig_ipv6 = connman_ipconfig_create(index,
+	if (service->ipconfig_ipv6 == NULL)
+		service->ipconfig_ipv6 = connman_ipconfig_create(index,
 						CONNMAN_IPCONFIG_TYPE_IPV6);
 	if (service->ipconfig_ipv6 == NULL)
 		return service;