From: David Cohen <david.a.cohen@linux.intel.com>
Date: Thu, 12 Sep 2013 00:42:47 +0000 (-0700)
Subject: usb: dwc3: gadget: avoid memory leak when failing to allocate all eps
X-Git-Tag: upstream/snapshot3+hdmi~4136^2~12^2~15
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e1f804676a95b9d5caaa3a822d90bc1101595468;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

usb: dwc3: gadget: avoid memory leak when failing to allocate all eps

If dwc3_gadget_init_endpoint() fails after allocate some of the eps, we
need to free their memory to avoid leak.

Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
---

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index f168eae..5452c0f 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -2611,15 +2611,13 @@ int dwc3_gadget_init(struct dwc3 *dwc)
 	ret = usb_add_gadget_udc(dwc->dev, &dwc->gadget);
 	if (ret) {
 		dev_err(dwc->dev, "failed to register udc\n");
-		goto err5;
+		goto err4;
 	}
 
 	return 0;
 
-err5:
-	dwc3_gadget_free_endpoints(dwc);
-
 err4:
+	dwc3_gadget_free_endpoints(dwc);
 	dma_free_coherent(dwc->dev, DWC3_EP0_BOUNCE_SIZE,
 			dwc->ep0_bounce, dwc->ep0_bounce_addr);