From: Antti Palosaari Date: Tue, 21 Aug 2012 22:56:19 +0000 (-0300) Subject: [media] rtl28xxu: fix rtl2832u module reload fails bug X-Git-Tag: upstream/snapshot3+hdmi~4891^2~1291 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e1f43269710daf3ab0d8d0da428f7f647c11676d;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git [media] rtl28xxu: fix rtl2832u module reload fails bug This is workaround / partial fix. rtl2832u_power_ctrl() and rtl2832u_frontend_attach() needs to be go through carefully and fix properly. There is clearly some logical errors when handling power-management ang GPIOs... Signed-off-by: Antti Palosaari Cc: Thomas Mair Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index 1ccb99b..c246c50 100644 --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c @@ -946,17 +946,6 @@ static int rtl2832u_power_ctrl(struct dvb_usb_device *d, int onoff) if (ret) goto err; - /* demod HW reset */ - ret = rtl28xx_rd_reg(d, SYS_DEMOD_CTL, &val); - if (ret) - goto err; - /* bit 5 to 0 */ - val &= 0xdf; - - ret = rtl28xx_wr_reg(d, SYS_DEMOD_CTL, val); - if (ret) - goto err; - ret = rtl28xx_rd_reg(d, SYS_DEMOD_CTL, &val); if (ret) goto err;