From: Jules Irenge Date: Mon, 20 Jan 2020 22:41:26 +0000 (+0000) Subject: rcu: Add missing annotation for exit_tasks_rcu_start() X-Git-Tag: v5.15~3785^2~18^2^6~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e1e9bdc00ade6651c11bf5628ee9d313ee6089ac;p=platform%2Fkernel%2Flinux-starfive.git rcu: Add missing annotation for exit_tasks_rcu_start() Sparse reports a warning at exit_tasks_rcu_start(void) |warning: context imbalance in exit_tasks_rcu_start() - wrong count at exit To fix this, this commit adds an __acquires(&tasks_rcu_exit_srcu). Given that exit_tasks_rcu_start() does actually call __srcu_read_lock(), this not only fixes the warning but also improves on the readability of the code. Signed-off-by: Jules Irenge Signed-off-by: Paul E. McKenney Reviewed-by: Joel Fernandes (Google) --- diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c index a27df76..a04fe54 100644 --- a/kernel/rcu/update.c +++ b/kernel/rcu/update.c @@ -801,7 +801,7 @@ static int __init rcu_spawn_tasks_kthread(void) core_initcall(rcu_spawn_tasks_kthread); /* Do the srcu_read_lock() for the above synchronize_srcu(). */ -void exit_tasks_rcu_start(void) +void exit_tasks_rcu_start(void) __acquires(&tasks_rcu_exit_srcu) { preempt_disable(); current->rcu_tasks_idx = __srcu_read_lock(&tasks_rcu_exit_srcu);